[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4 |
Date: |
Thu, 26 Nov 2020 13:13:10 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 26 Nov 2020 at 12:12, Daniel P. Berrangé <berrange@redhat.com> wrote:
>> On Thu, Nov 26, 2020 at 11:57:14AM +0000, Peter Maydell wrote:
>> > This is an interesting case, because it's a header intended
>> > for external use (people compiling plugins), not part of
>> > QEMU proper. I don't know whether we want to impose the
>> > same clang/gcc requirements on plugin builders, though it's
>> > probably not a bad idea to do so. Alex ?
>>
>> IIUC, we expect that the plugins are built specifically to go with
>> the QEMU you have built.
>
> No, the point of the plugin interface is that it actually is
> a (constrained) stable ABI with version-querying and checking
> so you don't have to build a plugin against the exact matching
> QEMU version. (But "don't use really ancient gcc" doesn't seem
> like a very major thing to ask of its users.)
Quite. But I agree using a GCC from this decade seems reasonable
especially as the feature has only been in QEMU for a few cycles.
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- Re: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler, (continued)
[PATCH v2 03/13] accel/tcg: Remove special case for GCC < 4.6, marcandre . lureau, 2020/11/26
[PATCH v2 04/13] compiler.h: remove GCC < 3 __builtin_expect fallback, marcandre . lureau, 2020/11/26
[PATCH v2 05/13] qemu-plugin.h: remove GCC < 4, marcandre . lureau, 2020/11/26
[PATCH v2 06/13] tests: remove GCC < 4 fallbacks, marcandre . lureau, 2020/11/26
[PATCH v2 07/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON, marcandre . lureau, 2020/11/26
[PATCH v2 08/13] compiler.h: explicit case for Clang printf attribute, marcandre . lureau, 2020/11/26
[PATCH v2 09/13] audio: remove GNUC & MSVC check, marcandre . lureau, 2020/11/26