Re: [PATCH for-6.0] qga/commands-posix: Send CCW address on s390x with the fsinfo data

[Cornelia Huck]

On Wed, 25 Nov 2020 11:54:17 +0100
Thomas Huth <thuth@redhat.com> wrote:

> We need the CCW address on the libvirt side to correctly identify
> the disk, so add this information to the GuestDiskAddress on s390x.
> 
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qga/commands-posix.c | 34 ++++++++++++++++++++++++++++++++++
>  qga/qapi-schema.json | 19 ++++++++++++++++++-
>  2 files changed, 52 insertions(+), 1 deletion(-)
> 

(...)

> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 3b3d1d0bd9..8be84b56e9 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -846,6 +846,21 @@
>    'data': {'domain': 'int', 'bus': 'int',
>             'slot': 'int', 'function': 'int'} }
>  
> +##
> +# @GuestCCWAddress:
> +#
> +# @cssid: channel subsystem image id
> +# @ssid: subchannel set id

You're missing subchno here.

> +# @devno:  device number
> +#
> +# Since: 6.0
> +##
> +{ 'struct': 'GuestCCWAddress',
> +  'data': {'cssid': 'int',
> +           'ssid': 'int',
> +           'subchno': 'int',
> +           'devno': 'int'} }
> +
>  ##
>  # @GuestDiskAddress:
>  #

(...)

Otherwise LGTM.