Re: [PATCH 37/36] machine: introduce MachineInitPhase

[Paolo Bonzini]

On 27/11/20 14:29, Igor Mammedov wrote:
> >   void qmp_set_numa_node(NumaOptions *cmd, Error **errp)
> >   {
> > -    if (qdev_hotplug) {
> > -         error_setg(errp, "The command is permitted only before the machine has 
> > been created");
> > -         return;
> > +    if (phase_check(PHASE_MACHINE_READY)) {
> that's what I was afraid of in 26/36,
> it should be PHASE_MACHINE_INITIALIZED
Indeed it should, and the same goes for qmp_x_exit_preconfig.  Also, 
it's probably best to add a comment to qemu_init_board, like

+    /* From here on we enter MACHINE_PHASE_INITIALIZED.  */
     machine_run_board_init(current_machine);

Paolo