[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper
From: |
Claudio Fontana |
Subject: |
Re: [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c |
Date: |
Sun, 29 Nov 2020 12:53:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 11/27/20 9:43 PM, Eduardo Habkost wrote:
> On Fri, Nov 27, 2020 at 08:47:00PM +0100, Claudio Fontana wrote:
>> On 11/27/20 8:04 PM, Eduardo Habkost wrote:
> [...]
>>> Maybe we should rename CPUClass.synchronize_from_tb to
>>> CPUClass.tcg_synchronize_from_tb? Maybe we should have a
>>
>> possibly, yes.
>>
>>> separate TCGCpuOperations struct to carry TCG-specific methods?
>>
>>
>> interesting, will think about it.
>
> I'm working on it at:
> https://gitlab.com/ehabkost/qemu/-/commits/work/tcg-cpu-ops
>
> Feel free to reuse it, if you want to do it before your series.
> Otherwise, I can rebase it after your series is merged.
>
> I didn't touch do_interrupt(), because of the aarch64 weirdness.
>
Hi,
yes it makes sense to separate more clearly I think what is tcg only among
those operations,
it is a bit tangent to my series in the sense that those methods need to be set
one way or another,
either in cc-> or in cc->tcg_ops,
but yes, we could put those changes before or after the series, and I think
they make sense.
Ciao,
Claudio
- [RFC v6 02/11] i386: move whpx accel files into whpx/, (continued)
- [RFC v6 02/11] i386: move whpx accel files into whpx/, Claudio Fontana, 2020/11/26
- [RFC v6 03/11] i386: move hax accel files into hax/, Claudio Fontana, 2020/11/26
- [RFC v6 08/11] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2020/11/26
- [RFC v6 06/11] i386: move cpu dump out of helper.c into cpu-dump.c, Claudio Fontana, 2020/11/26
- [RFC v6 05/11] i386: move TCG accel files into tcg/, Claudio Fontana, 2020/11/26
- [RFC v6 04/11] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs, Claudio Fontana, 2020/11/26
- [RFC v6 07/11] i386: move TCG cpu class initialization out of helper.c, Claudio Fontana, 2020/11/26
[RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2020/11/26
- Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Paolo Bonzini, 2020/11/27
- Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2020/11/27
- Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2020/11/27
- Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2020/11/27
- Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Paolo Bonzini, 2020/11/27
- Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2020/11/27
Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass, Eduardo Habkost, 2020/11/27