qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 1/1] hw/sd: Fix 2 GiB card CSD register values


From: Peter Maydell
Subject: Re: [PULL 1/1] hw/sd: Fix 2 GiB card CSD register values
Date: Mon, 30 Nov 2020 12:54:49 +0000

On Mon, 30 Nov 2020 at 12:53, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> +Peter,
>
> On Tue, Nov 17, 2020 at 6:52 PM Philippe Mathieu-Daudé <f4bug@amsat.org> 
> wrote:
> >
> > From: Bin Meng <bin.meng@windriver.com>
> >
> > Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024
> > bytes, hence the READ_BL_LEN field in the CSD register shall be 10
> > instead of 9.
> >
> > This fixes the acceptance test error for the NetBSD 9.0 test of the
> > Orange Pi PC that has an expanded SD card image of 2 GiB size.
> >
> > Fixes: 6d2d4069c47e ("hw/sd: Correct the maximum size of a Standard 
> > Capacity SD Memory Card")
> > Reported-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > Tested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> > Message-Id: <20201025152357.11865-1-bmeng.cn@gmail.com>
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  hw/sd/sd.c | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> >
>
> Any chance to get this patch applied to 5.2 since it's a bug fix?

It's already in -- commit 575094b786e999e5fbd0.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]