Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code

[Markus Armbruster]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 9 Nov 2020 at 09:01, Markus Armbruster <armbru@redhat.com> wrote:
>> CODING_STYLE.rst: "Lines should be 80 characters; try not to make them
>> longer."  I'd like to keep the tooling we have to help us with trying
>> not to make them longer.
>>
>> If we have lost the ability to differentiate between "warning" and
>> "error", call it something else.
>
> Personally I just want checkpatch with its default arguments not
> to complain about code that we'd be happy to accept in the tree.

This means losing complaints about code we don't want to accept, because
there is a grey area where checkpatch can't be sure.

CODING_STYLE.rst demands "try not to make lines longer than 80
characters, but if you decide you need to, don't make them longer than
90".

As long as we have this grey area where we want developers to try,
checkpatch's job is to remind them to try.

> It's unnecessary noise when I write and check the code locally,
> when patchew runs on the patch on the list and then when it goes
> into a pullreq.

Checking locally: noise or not is up to you.

Patchew: no, it's not noise here.  Patch review is exactly where the
reminder is needed.

Pull request: assuming patch review did its job, all that's left is
noise.

>                 Do we need a new "be really strict" option?

No objection, as long as we stick to strict for patch review.