[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 2/7] block/nbd.c: Add yank feature

From: Lukas Straub
Subject: Re: [PATCH v11 2/7] block/nbd.c: Add yank feature
Date: Wed, 2 Dec 2020 13:34:36 +0100

On Wed, 2 Dec 2020 15:18:48 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:

> 15.11.2020 14:36, Lukas Straub wrote:
> > Register a yank function which shuts down the socket and sets
> > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
> > error occured.
> > 
> > Signed-off-by: Lukas Straub<lukasstraub2@web.de>
> > Acked-by: Stefan Hajnoczi<stefanha@redhat.com>  
> Hi! Could I ask, what's the reason for qatomic_load_acquire access to 
> s->state? Is there same bug fixed? Or is it related somehow to new feature?

This is for the new feature, as the yank function runs in a separate thread.

Lukas Straub


Attachment: pgpPzLDq0yhzQ.pgp
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]