[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT d
|
From: |
Julia Suvorova |
|
Subject: |
Re: [PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition |
|
Date: |
Wed, 2 Dec 2020 16:05:23 +0100 |
On Wed, Dec 2, 2020 at 2:24 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> While this change helps triskaidekaphobic developers, it
> is a good practice to avoid magic values and using constant
> definitions instead.
>
> Introduce the PAM_REGIONS_COUNT and use it. No logical change.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/hw/pci-host/i440fx.h | 2 +-
> include/hw/pci-host/pam.h | 2 ++
> include/hw/pci-host/q35.h | 2 +-
> hw/pci-host/pam.c | 2 +-
> hw/pci-host/q35.c | 2 +-
> 5 files changed, 6 insertions(+), 4 deletions(-)
:D
Reviewed-by: Julia Suvorova <jusual@redhat.com>