[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v9 01/32] accel/tcg: split CpusAccel into three TCG variants
From: |
Alex Bennée |
Subject: |
Re: [RFC v9 01/32] accel/tcg: split CpusAccel into three TCG variants |
Date: |
Wed, 09 Dec 2020 08:34:24 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Claudio Fontana <cfontana@suse.de> writes:
> split up the CpusAccel tcg_cpus into three TCG variants:
>
> tcg_cpus_rr (single threaded, round robin cpus)
> tcg_cpus_icount (same as rr, but with instruction counting enabled)
> tcg_cpus_mttcg (multi-threaded cpus)
>
<snip>
> diff --git a/accel/tcg/tcg-cpus-mttcg.c b/accel/tcg/tcg-cpus-mttcg.c
> new file mode 100644
> index 0000000000..dac724fc85
> --- /dev/null
> +++ b/accel/tcg/tcg-cpus-mttcg.c
> @@ -0,0 +1,117 @@
<snip>
> +
> +/*
> + * In the multi-threaded case each vCPU has its own thread. The TLS
> + * variable current_cpu can be used deep in the code to find the
> + * current CPUState for a given thread.
> + */
> +
<snip>
> +
> +/*
> + * In the multi-threaded case each vCPU has its own thread. The TLS
> + * variable current_cpu can be used deep in the code to find the
> + * current CPUState for a given thread.
> + */
nit: This is overly repetitive - I think we can drop the duplication in
the header. If anything the comment should probably be re-formulated at
the current_cpu definition in cpus-common.
<snip>
Otherwise nice clean-up ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [RFC v9 00/22] i386 cleanup, Claudio Fontana, 2020/12/08
- [RFC v9 02/32] accel/tcg: split tcg_start_vcpu_thread, Claudio Fontana, 2020/12/08
- [RFC v9 03/32] accel/tcg: rename tcg-cpus functions to match module name, Claudio Fontana, 2020/12/08
- [RFC v9 04/32] i386: move kvm accel files into kvm/, Claudio Fontana, 2020/12/08
- [RFC v9 01/32] accel/tcg: split CpusAccel into three TCG variants, Claudio Fontana, 2020/12/08
- Re: [RFC v9 01/32] accel/tcg: split CpusAccel into three TCG variants,
Alex Bennée <=
- [RFC v9 05/32] i386: move whpx accel files into whpx/, Claudio Fontana, 2020/12/08
- [RFC v9 06/32] i386: move hax accel files into hax/, Claudio Fontana, 2020/12/08
- [RFC v9 07/32] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs, Claudio Fontana, 2020/12/08
- [RFC v9 08/32] i386: move TCG accel files into tcg/, Claudio Fontana, 2020/12/08
- [RFC v9 09/32] i386: move cpu dump out of helper.c into cpu-dump.c, Claudio Fontana, 2020/12/08