qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v9 08/32] i386: move TCG accel files into tcg/


From: Alex Bennée
Subject: Re: [RFC v9 08/32] i386: move TCG accel files into tcg/
Date: Wed, 09 Dec 2020 09:30:56 +0000
User-agent: mu4e 1.5.7; emacs 28.0.50

Claudio Fontana <cfontana@suse.de> writes:

> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
>  target/i386/meson.build             | 14 +-------------
>  target/i386/{ => tcg}/bpt_helper.c  |  0
>  target/i386/{ => tcg}/cc_helper.c   |  0
>  target/i386/{ => tcg}/excp_helper.c |  0
>  target/i386/{ => tcg}/fpu_helper.c  |  0
>  target/i386/{ => tcg}/int_helper.c  |  0
>  target/i386/{ => tcg}/mem_helper.c  |  0
>  target/i386/tcg/meson.build         | 13 +++++++++++++
>  target/i386/{ => tcg}/misc_helper.c |  0
>  target/i386/{ => tcg}/mpx_helper.c  |  0
>  target/i386/{ => tcg}/seg_helper.c  |  0
>  target/i386/{ => tcg}/smm_helper.c  |  0
>  target/i386/{ => tcg}/svm_helper.c  |  0
>  target/i386/{ => tcg}/tcg-stub.c    |  0
>  target/i386/{ => tcg}/translate.c   |  0
>  15 files changed, 14 insertions(+), 13 deletions(-)
>  rename target/i386/{ => tcg}/bpt_helper.c (100%)
>  rename target/i386/{ => tcg}/cc_helper.c (100%)
>  rename target/i386/{ => tcg}/excp_helper.c (100%)
>  rename target/i386/{ => tcg}/fpu_helper.c (100%)
>  rename target/i386/{ => tcg}/int_helper.c (100%)
>  rename target/i386/{ => tcg}/mem_helper.c (100%)
>  create mode 100644 target/i386/tcg/meson.build
>  rename target/i386/{ => tcg}/misc_helper.c (100%)
>  rename target/i386/{ => tcg}/mpx_helper.c (100%)
>  rename target/i386/{ => tcg}/seg_helper.c (100%)
>  rename target/i386/{ => tcg}/smm_helper.c (100%)
>  rename target/i386/{ => tcg}/svm_helper.c (100%)
>  rename target/i386/{ => tcg}/tcg-stub.c (100%)
>  rename target/i386/{ => tcg}/translate.c (100%)

I noticed target/i386/helper-tcg.h is still in the main directory. It
maybe be a straggler that is harder to separate - if so might be worth
mentioning in the commit message. Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]