Re: [RFC v9 00/22] i386 cleanup

[Alex Bennée]

no-reply@patchew.org writes:

> Patchew URL: 20201208194839.31305-1-cfontana@suse.de/">https://patchew.org/QEMU/20201208194839.31305-1-cfontana@suse.de/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:

Also replicated in:

https://gitlab.com/stsquad/qemu/-/jobs/899057106

>
> Type: series
> Message-id: 20201208194839.31305-1-cfontana@suse.de
> Subject: [RFC v9 00/22] i386 cleanup
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/20201208194839.31305-1-cfontana@suse.de -> 
> patchew/20201208194839.31305-1-cfontana@suse.de
> Switched to a new branch 'test'
> 1df468e cpu: introduce cpu_accel_instance_init
> 273e6bc hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn
> 6c8c6a4 cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
> c7ecc11 i386: split cpu accelerators from cpu.c, using AccelCPUClass
> 739ef2b accel: introduce AccelCPUClass extending CPUClass
> 706469e accel: replace struct CpusAccel with AccelOpsClass
> c3aa222 accel: extend AccelState and AccelClass to user-mode
> c45684a cpu: move do_unaligned_access to tcg_ops
> bca539a cpu: move cc->transaction_failed to tcg_ops
> 74feabd cpu: move cc->do_interrupt to tcg_ops
> f22d896 target/arm: do not use cc->do_interrupt for KVM directly
> 9a74429 cpu: Move debug_excp_handler to tcg_ops
> bf5b24b cpu: Move tlb_fill to tcg_ops
> 481a06e cpu: Move cpu_exec_* to tcg_ops
> af72917 cpu: Move synchronize_from_tb() to tcg_ops
> f9b393d accel/tcg: split TCG-only code from cpu_exec_realizefn
> 2019e4f target/riscv: remove CONFIG_TCG, as it is always TCG
> 53b3f4e cpu: Introduce TCGCpuOperations struct
> 8a0c2e9 cpu: Remove unnecessary noop methods
> 043b89c tcg: Make CPUClass.debug_excp_handler optional
> b271ab4 tcg: make CPUClass.cpu_exec_* optional
> ac15b62 tcg: cpu_exec_{enter,exit} helpers
> 0560b09 i386: move TCG cpu class initialization out of helper.c
> 36ae5f1 i386: move cpu dump out of helper.c into cpu-dump.c
> ef2d207 i386: move TCG accel files into tcg/
> 9d7a737 i386: hvf: remove stale MAINTAINERS entry for old hvf stubs
> 42deca7 i386: move hax accel files into hax/
> 7dfc2be i386: move whpx accel files into whpx/
> 4d4c885 i386: move kvm accel files into kvm/
> d9966d5 accel/tcg: rename tcg-cpus functions to match module name
> a8f0cbf accel/tcg: split tcg_start_vcpu_thread
> 5e46bf0 accel/tcg: split CpusAccel into three TCG variants
>
> === OUTPUT BEGIN ===
> 1/32 Checking commit 5e46bf019fb7 (accel/tcg: split CpusAccel into three TCG 
> variants)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #57: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 1156 lines checked
>
> Patch 1/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 2/32 Checking commit a8f0cbf6b610 (accel/tcg: split tcg_start_vcpu_thread)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #103: 
> deleted file mode 100644
>
> total: 0 errors, 1 warnings, 201 lines checked
>
> Patch 2/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 3/32 Checking commit d9966d571c7e (accel/tcg: rename tcg-cpus functions to 
> match module name)
> 4/32 Checking commit 4d4c885ff790 (i386: move kvm accel files into kvm/)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #167: 
> rename from target/i386/hyperv-proto.h
>
> total: 0 errors, 1 warnings, 150 lines checked
>
> Patch 4/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 5/32 Checking commit 7dfc2bea3c57 (i386: move whpx accel files into whpx/)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #50: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 32 lines checked
>
> Patch 5/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 6/32 Checking commit 42deca72cda4 (i386: move hax accel files into hax/)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #25: 
> rename from target/i386/hax-all.c
>
> total: 0 errors, 1 warnings, 47 lines checked
>
> Patch 6/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 7/32 Checking commit 9d7a7374d252 (i386: hvf: remove stale MAINTAINERS entry 
> for old hvf stubs)
> 8/32 Checking commit ef2d207c5f81 (i386: move TCG accel files into tcg/)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #44: 
> rename from target/i386/bpt_helper.c
>
> total: 0 errors, 1 warnings, 39 lines checked
>
> Patch 8/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 9/32 Checking commit 36ae5f191d8c (i386: move cpu dump out of helper.c into 
> cpu-dump.c)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #11: 
> new file mode 100644
>
> ERROR: braces {} are necessary for all arms of this statement
> #128: FILE: target/i386/cpu-dump.c:113:
> +    if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK))
> [...]
>
> WARNING: Block comments use a leading /* on a separate line
> #172: FILE: target/i386/cpu-dump.c:157:
> +/* ARRAY_SIZE check is not required because
>
> WARNING: Block comments use a leading /* on a separate line
> #211: FILE: target/i386/cpu-dump.c:196:
> +/* ARRAY_SIZE check is not required because
>
> ERROR: line over 90 characters
> #373: FILE: target/i386/cpu-dump.c:358:
> +        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" 
> PRIx64 " RDX=%016" PRIx64 "\n"
>
> ERROR: line over 90 characters
> #374: FILE: target/i386/cpu-dump.c:359:
> +                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 
> " RSP=%016" PRIx64 "\n"
>
> ERROR: line over 90 characters
> #375: FILE: target/i386/cpu-dump.c:360:
> +                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 
> " R11=%016" PRIx64 "\n"
>
> ERROR: line over 90 characters
> #376: FILE: target/i386/cpu-dump.c:361:
> +                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 
> " R15=%016" PRIx64 "\n"
>
> ERROR: line over 90 characters
> #377: FILE: target/i386/cpu-dump.c:362:
> +                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d 
> II=%d A20=%d SMM=%d HLT=%d\n",
>
> ERROR: space required before the open parenthesis '('
> #436: FILE: target/i386/cpu-dump.c:421:
> +    for(i = 0; i < 6; i++) {
>
> WARNING: line over 80 characters
> #448: FILE: target/i386/cpu-dump.c:433:
> +        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " 
> CR4=%08x\n",
>
> ERROR: space required before the open parenthesis '('
> #453: FILE: target/i386/cpu-dump.c:438:
> +        for(i = 0; i < 4; i++)
>
> ERROR: braces {} are necessary for all arms of this statement
> #453: FILE: target/i386/cpu-dump.c:438:
> +        for(i = 0; i < 4; i++)
> [...]
>
> ERROR: space required before the open parenthesis '('
> #469: FILE: target/i386/cpu-dump.c:454:
> +        for(i = 0; i < 4; i++) {
>
> ERROR: braces {} are necessary for all arms of this statement
> #476: FILE: target/i386/cpu-dump.c:461:
> +        if ((unsigned)env->cc_op < CC_OP_NB)
> [...]
> +        else
> [...]
>
> WARNING: line over 80 characters
> #477: FILE: target/i386/cpu-dump.c:462:
> +            snprintf(cc_op_name, sizeof(cc_op_name), "%s", 
> cc_op_str[env->cc_op]);
>
> ERROR: space required before the open parenthesis '('
> #497: FILE: target/i386/cpu-dump.c:482:
> +        for(i = 0; i < 8; i++) {
>
> ERROR: spaces required around that '=' (ctx:VxV)
> #507: FILE: target/i386/cpu-dump.c:492:
> +        for(i=0;i<8;i++) {
>               ^
>
> ERROR: space required after that ';' (ctx:VxV)
> #507: FILE: target/i386/cpu-dump.c:492:
> +        for(i=0;i<8;i++) {
>                 ^
>
> ERROR: spaces required around that '<' (ctx:VxV)
> #507: FILE: target/i386/cpu-dump.c:492:
> +        for(i=0;i<8;i++) {
>                   ^
>
> ERROR: space required after that ';' (ctx:VxV)
> #507: FILE: target/i386/cpu-dump.c:492:
> +        for(i=0;i<8;i++) {
>                     ^
>
> ERROR: space required before the open parenthesis '('
> #507: FILE: target/i386/cpu-dump.c:492:
> +        for(i=0;i<8;i++) {
>
> ERROR: braces {} are necessary for all arms of this statement
> #512: FILE: target/i386/cpu-dump.c:497:
> +            if ((i & 1) == 1)
> [...]
> +            else
> [...]
>
> ERROR: braces {} are necessary for all arms of this statement
> #517: FILE: target/i386/cpu-dump.c:502:
> +        if (env->hflags & HF_CS64_MASK)
> [...]
> +        else
> [...]
>
> ERROR: spaces required around that '=' (ctx:VxV)
> #521: FILE: target/i386/cpu-dump.c:506:
> +        for(i=0;i<nb;i++) {
>               ^
>
> ERROR: space required after that ';' (ctx:VxV)
> #521: FILE: target/i386/cpu-dump.c:506:
> +        for(i=0;i<nb;i++) {
>                 ^
>
> ERROR: spaces required around that '<' (ctx:VxV)
> #521: FILE: target/i386/cpu-dump.c:506:
> +        for(i=0;i<nb;i++) {
>                   ^
>
> ERROR: space required after that ';' (ctx:VxV)
> #521: FILE: target/i386/cpu-dump.c:506:
> +        for(i=0;i<nb;i++) {
>                      ^
>
> ERROR: space required before the open parenthesis '('
> #521: FILE: target/i386/cpu-dump.c:506:
> +        for(i=0;i<nb;i++) {
>
> ERROR: braces {} are necessary for all arms of this statement
> #528: FILE: target/i386/cpu-dump.c:513:
> +            if ((i & 1) == 1)
> [...]
> +            else
> [...]
>
> total: 25 errors, 5 warnings, 1077 lines checked
>
> Patch 9/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 10/32 Checking commit 0560b09d8481 (i386: move TCG cpu class initialization 
> out of helper.c)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #282: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 610 lines checked
>
> Patch 10/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 11/32 Checking commit ac15b624a91f (tcg: cpu_exec_{enter,exit} helpers)
> 12/32 Checking commit b271ab48c45b (tcg: make CPUClass.cpu_exec_* optional)
> 13/32 Checking commit 043b89c9c315 (tcg: Make CPUClass.debug_excp_handler 
> optional)
> 14/32 Checking commit 8a0c2e9a0e2c (cpu: Remove unnecessary noop methods)
> 15/32 Checking commit 53b3f4e5b390 (cpu: Introduce TCGCpuOperations struct)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #92: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 301 lines checked
>
> Patch 15/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 16/32 Checking commit 2019e4f802bb (target/riscv: remove CONFIG_TCG, as it is 
> always TCG)
> 17/32 Checking commit f9b393d26c70 (accel/tcg: split TCG-only code from 
> cpu_exec_realizefn)
> 18/32 Checking commit af729170f4b8 (cpu: Move synchronize_from_tb() to 
> tcg_ops)
> 19/32 Checking commit 481a06e3b020 (cpu: Move cpu_exec_* to tcg_ops)
> 20/32 Checking commit bf5b24bcd22f (cpu: Move tlb_fill to tcg_ops)
> WARNING: line over 80 characters
> #22: FILE: accel/tcg/cputlb.c:1289:
> +    ok = cc->tcg_ops.tlb_fill(cpu, addr, size, access_type, mmu_idx, false, 
> retaddr);
>
> total: 0 errors, 1 warnings, 259 lines checked
>
> Patch 20/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 21/32 Checking commit 9a74429f2029 (cpu: Move debug_excp_handler to tcg_ops)
> 22/32 Checking commit f22d896967f8 (target/arm: do not use cc->do_interrupt 
> for KVM directly)
> 23/32 Checking commit 74feabd5bae5 (cpu: move cc->do_interrupt to tcg_ops)
> 24/32 Checking commit bca539a6251e (cpu: move cc->transaction_failed to 
> tcg_ops)
> WARNING: line over 80 characters
> #67: FILE: include/hw/core/cpu.h:857:
> +        cc->tcg_ops.do_transaction_failed(cpu, physaddr, addr, size, 
> access_type,
>
> total: 0 errors, 1 warnings, 144 lines checked
>
> Patch 24/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 25/32 Checking commit c45684ac5ad9 (cpu: move do_unaligned_access to tcg_ops)
> 26/32 Checking commit c3aa2224bd71 (accel: extend AccelState and AccelClass 
> to user-mode)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #24: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 359 lines checked
>
> Patch 26/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 27/32 Checking commit 706469ebcc15 (accel: replace struct CpusAccel with 
> AccelOpsClass)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #115: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 691 lines checked
>
> Patch 27/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 28/32 Checking commit 739ef2bd13aa (accel: introduce AccelCPUClass extending 
> CPUClass)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #99: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 123 lines checked
>
> Patch 28/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 29/32 Checking commit c7ecc117664f (i386: split cpu accelerators from cpu.c, 
> using AccelCPUClass)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #664: 
> new file mode 100644
>
> WARNING: line over 80 characters
> #1435: FILE: target/i386/tcg/cpu.c:104:
> +    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, 
> cpu->cpu_as_mem, 0);
>
> total: 0 errors, 2 warnings, 1296 lines checked
>
> Patch 29/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 30/32 Checking commit 6c8c6a4d84dd (cpu: call AccelCPUClass::cpu_realizefn in 
> cpu_exec_realizefn)
> 31/32 Checking commit 273e6bca6404 (hw/core/cpu: call qemu_init_vcpu in 
> cpu_common_realizefn)
> 32/32 Checking commit 1df468eafd63 (cpu: introduce cpu_accel_instance_init)
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
> 20201208194839.31305-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20201208194839.31305-1-cfontana@suse.de/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com


-- 
Alex Bennée