[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v9 18/32] cpu: Move synchronize_from_tb() to tcg_ops
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC v9 18/32] cpu: Move synchronize_from_tb() to tcg_ops |
Date: |
Wed, 9 Dec 2020 16:06:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/9/20 3:33 PM, Claudio Fontana wrote:
> Hi Philippe,
>
> On 12/9/20 10:27 AM, Philippe Mathieu-Daudé wrote:
>> On 12/8/20 8:48 PM, Claudio Fontana wrote:
>>> From: Eduardo Habkost <ehabkost@redhat.com>
>>>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>> [claudio: wrapped in CONFIG_TCG]
>>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>> ...
>>> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
>>> index 4475ef0996..109291ac52 100644
>>> --- a/include/hw/core/tcg-cpu-ops.h
>>> +++ b/include/hw/core/tcg-cpu-ops.h
>>> @@ -10,9 +10,6 @@
>>> #ifndef TCG_CPU_OPS_H
>>> #define TCG_CPU_OPS_H
>>
>> Missing for TranslationBlock:
>>
>> #include "hw/core/cpu.h"
>
>
> this file though is only included from hw/core/cpu.h itself under CONFIG_TCG..
1/ we never know how it will be included, includes should
be self-contained IMO.
2/ my editor isn't that smart and can't figure out the types.
[RFC v9 19/32] cpu: Move cpu_exec_* to tcg_ops, Claudio Fontana, 2020/12/08
[RFC v9 24/32] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2020/12/08