[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] kvm: Take into account the unaligned section size when prepa
|
From: |
zhukeqian |
|
Subject: |
Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap |
|
Date: |
Thu, 10 Dec 2020 10:53:23 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 2020/12/10 10:08, Peter Xu wrote:
> Keqian,
>
> On Thu, Dec 10, 2020 at 09:46:06AM +0800, zhukeqian wrote:
>> Hi,
>>
>> I see that if start or size is not PAGE aligned, it also clears areas
>> which beyond caller's expectation, so do we also need to consider this?
>
> Could you elaborate?
>
> If start_delta != 0, kvm_log_clear_one_slot() should already go the slow path.
>
> Thanks,
>
Hi Peter,
start_delta /= psize;
If start is not PAGE aligned, then start_delta is not PAGE aligned.
so I think the above code will implicitly extend our start to be PAGE aligned.
I suggest that we should shrink the start and (start + size) to be PAGE aligned
at beginning of this function.
Maybe I miss something?
Keqian.
- [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Zenghui Yu, 2020/12/08
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Peter Xu, 2020/12/08
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Zenghui Yu, 2020/12/08
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, zhukeqian, 2020/12/09
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Peter Xu, 2020/12/09
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap,
zhukeqian <=
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Zenghui Yu, 2020/12/09
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Peter Xu, 2020/12/10
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, zhukeqian, 2020/12/10
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Peter Xu, 2020/12/11
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, zhukeqian, 2020/12/13
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Peter Xu, 2020/12/14
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, zhukeqian, 2020/12/15
- Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap, Zenghui Yu, 2020/12/15