Re: [PATCH v11 00/25] i386 cleanup PART 1

[no-reply]

Patchew URL: 20201211083143.14350-1-cfontana@suse.de/">https://patchew.org/QEMU/20201211083143.14350-1-cfontana@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201211083143.14350-1-cfontana@suse.de
Subject: [PATCH v11 00/25] i386 cleanup PART 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201210190417.31673-1-alex.bennee@linaro.org -> 
patchew/20201210190417.31673-1-alex.bennee@linaro.org
 - [tag update]      patchew/20201210223506.263709-1-philmd@redhat.com -> 
patchew/20201210223506.263709-1-philmd@redhat.com
 * [new tag]         patchew/20201211083143.14350-1-cfontana@suse.de -> 
patchew/20201211083143.14350-1-cfontana@suse.de
Switched to a new branch 'test'
a3c83d9 cpu: move do_unaligned_access to tcg_ops
0aecd32 cpu: move cc->transaction_failed to tcg_ops
f569b71 cpu: move cc->do_interrupt to tcg_ops
d72487e target/arm: do not use cc->do_interrupt for KVM directly
32ccc60 cpu: Move debug_excp_handler to tcg_ops
7bb4177 cpu: Move tlb_fill to tcg_ops
79fab44 cpu: Move cpu_exec_* to tcg_ops
cb83174 cpu: Move synchronize_from_tb() to tcg_ops
ecfd44d accel/tcg: split TCG-only code from cpu_exec_realizefn
de4c296 target/riscv: remove CONFIG_TCG, as it is always TCG
c279736 cpu: Introduce TCGCpuOperations struct
bd1deaa cpu: Remove unnecessary noop methods
07018b9 tcg: Make CPUClass.debug_excp_handler optional
e331244 tcg: make CPUClass.cpu_exec_* optional
b26f65d tcg: cpu_exec_{enter,exit} helpers
d7314ca i386: move TCG cpu class initialization out of helper.c
658aed7 i386: move cpu dump out of helper.c into cpu-dump.c
4afbc49 i386: move TCG accel files into tcg/
5904058 i386: hvf: remove stale MAINTAINERS entry for old hvf stubs
ddfe357 i386: move hax accel files into hax/
01e7019 i386: move whpx accel files into whpx/
5f8a34a i386: move kvm accel files into kvm/
1811a42 accel/tcg: rename tcg-cpus functions to match module name
b20ad72 accel/tcg: split tcg_start_vcpu_thread
93622c5 accel/tcg: split CpusAccel into three TCG variants

=== OUTPUT BEGIN ===
1/25 Checking commit 93622c51d180 (accel/tcg: split CpusAccel into three TCG 
variants)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 1156 lines checked

Patch 1/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/25 Checking commit b20ad7218d38 (accel/tcg: split tcg_start_vcpu_thread)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#103: 
deleted file mode 100644

total: 0 errors, 1 warnings, 201 lines checked

Patch 2/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/25 Checking commit 1811a42dd7b5 (accel/tcg: rename tcg-cpus functions to 
match module name)
4/25 Checking commit 5f8a34a38c95 (i386: move kvm accel files into kvm/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#168: 
rename from target/i386/hyperv-proto.h

total: 0 errors, 1 warnings, 150 lines checked

Patch 4/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/25 Checking commit 01e70198abda (i386: move whpx accel files into whpx/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 32 lines checked

Patch 5/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/25 Checking commit ddfe3572963a (i386: move hax accel files into hax/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
rename from target/i386/hax-all.c

total: 0 errors, 1 warnings, 47 lines checked

Patch 6/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/25 Checking commit 59040585f5e0 (i386: hvf: remove stale MAINTAINERS entry 
for old hvf stubs)
8/25 Checking commit 4afbc49cc900 (i386: move TCG accel files into tcg/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
rename from target/i386/bpt_helper.c

total: 0 errors, 1 warnings, 39 lines checked

Patch 8/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/25 Checking commit 658aed78b5fa (i386: move cpu dump out of helper.c into 
cpu-dump.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100644

ERROR: braces {} are necessary for all arms of this statement
#129: FILE: target/i386/cpu-dump.c:113:
+    if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK))
[...]

WARNING: Block comments use a leading /* on a separate line
#173: FILE: target/i386/cpu-dump.c:157:
+/* ARRAY_SIZE check is not required because

WARNING: Block comments use a leading /* on a separate line
#212: FILE: target/i386/cpu-dump.c:196:
+/* ARRAY_SIZE check is not required because

ERROR: line over 90 characters
#374: FILE: target/i386/cpu-dump.c:358:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" 
PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#375: FILE: target/i386/cpu-dump.c:359:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " 
RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#376: FILE: target/i386/cpu-dump.c:360:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " 
R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#377: FILE: target/i386/cpu-dump.c:361:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " 
R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#378: FILE: target/i386/cpu-dump.c:362:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d 
II=%d A20=%d SMM=%d HLT=%d\n",

ERROR: space required before the open parenthesis '('
#437: FILE: target/i386/cpu-dump.c:421:
+    for(i = 0; i < 6; i++) {

WARNING: line over 80 characters
#449: FILE: target/i386/cpu-dump.c:433:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " 
CR4=%08x\n",

ERROR: space required before the open parenthesis '('
#454: FILE: target/i386/cpu-dump.c:438:
+        for(i = 0; i < 4; i++)

ERROR: braces {} are necessary for all arms of this statement
#454: FILE: target/i386/cpu-dump.c:438:
+        for(i = 0; i < 4; i++)
[...]

ERROR: space required before the open parenthesis '('
#470: FILE: target/i386/cpu-dump.c:454:
+        for(i = 0; i < 4; i++) {

ERROR: braces {} are necessary for all arms of this statement
#477: FILE: target/i386/cpu-dump.c:461:
+        if ((unsigned)env->cc_op < CC_OP_NB)
[...]
+        else
[...]

WARNING: line over 80 characters
#478: FILE: target/i386/cpu-dump.c:462:
+            snprintf(cc_op_name, sizeof(cc_op_name), "%s", 
cc_op_str[env->cc_op]);

ERROR: space required before the open parenthesis '('
#498: FILE: target/i386/cpu-dump.c:482:
+        for(i = 0; i < 8; i++) {

ERROR: spaces required around that '=' (ctx:VxV)
#508: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
              ^

ERROR: space required after that ';' (ctx:VxV)
#508: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
                ^

ERROR: spaces required around that '<' (ctx:VxV)
#508: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
                  ^

ERROR: space required after that ';' (ctx:VxV)
#508: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
                    ^

ERROR: space required before the open parenthesis '('
#508: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {

ERROR: braces {} are necessary for all arms of this statement
#513: FILE: target/i386/cpu-dump.c:497:
+            if ((i & 1) == 1)
[...]
+            else
[...]

ERROR: braces {} are necessary for all arms of this statement
#518: FILE: target/i386/cpu-dump.c:502:
+        if (env->hflags & HF_CS64_MASK)
[...]
+        else
[...]

ERROR: spaces required around that '=' (ctx:VxV)
#522: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
              ^

ERROR: space required after that ';' (ctx:VxV)
#522: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
                ^

ERROR: spaces required around that '<' (ctx:VxV)
#522: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
                  ^

ERROR: space required after that ';' (ctx:VxV)
#522: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
                     ^

ERROR: space required before the open parenthesis '('
#522: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {

ERROR: braces {} are necessary for all arms of this statement
#529: FILE: target/i386/cpu-dump.c:513:
+            if ((i & 1) == 1)
[...]
+            else
[...]

total: 25 errors, 5 warnings, 1077 lines checked

Patch 9/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/25 Checking commit d7314cab76a0 (i386: move TCG cpu class initialization out 
of helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#412: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 10/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/25 Checking commit b26f65d8444f (tcg: cpu_exec_{enter,exit} helpers)
12/25 Checking commit e33124412d9d (tcg: make CPUClass.cpu_exec_* optional)
13/25 Checking commit 07018b947480 (tcg: Make CPUClass.debug_excp_handler 
optional)
14/25 Checking commit bd1deaa726fc (cpu: Remove unnecessary noop methods)
15/25 Checking commit c27973682908 (cpu: Introduce TCGCpuOperations struct)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 0 errors, 1 warnings, 301 lines checked

Patch 15/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/25 Checking commit de4c29651b51 (target/riscv: remove CONFIG_TCG, as it is 
always TCG)
17/25 Checking commit ecfd44dde593 (accel/tcg: split TCG-only code from 
cpu_exec_realizefn)
18/25 Checking commit cb8317496f91 (cpu: Move synchronize_from_tb() to tcg_ops)
19/25 Checking commit 79fab444bec5 (cpu: Move cpu_exec_* to tcg_ops)
20/25 Checking commit 7bb4177e62f9 (cpu: Move tlb_fill to tcg_ops)
WARNING: line over 80 characters
#23: FILE: accel/tcg/cputlb.c:1289:
+    ok = cc->tcg_ops.tlb_fill(cpu, addr, size, access_type, mmu_idx, false, 
retaddr);

total: 0 errors, 1 warnings, 259 lines checked

Patch 20/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/25 Checking commit 32ccc60a6d38 (cpu: Move debug_excp_handler to tcg_ops)
22/25 Checking commit d72487ea4fa7 (target/arm: do not use cc->do_interrupt for 
KVM directly)
23/25 Checking commit f569b716427c (cpu: move cc->do_interrupt to tcg_ops)
24/25 Checking commit 0aecd322182a (cpu: move cc->transaction_failed to tcg_ops)
WARNING: line over 80 characters
#87: FILE: include/hw/core/cpu.h:857:
+        cc->tcg_ops.do_transaction_failed(cpu, physaddr, addr, size, 
access_type,

total: 0 errors, 1 warnings, 195 lines checked

Patch 24/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/25 Checking commit a3c83d9f6296 (cpu: move do_unaligned_access to tcg_ops)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201211083143.14350-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20201211083143.14350-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com