Re: [PATCH v2 4/8] configure: add --without-default-features

[Alex Bennée]

Thomas Huth <thuth@redhat.com> writes:

> On 10/12/2020 20.04, Alex Bennée wrote:
>> By default QEMU enables a lot of features if it can probe and find the
>> support libraries. It also enables a bunch of features by default.
>> This patch adds the ability to build --without-default-features which
>> can be paired with a --without-default-devices for a barely functional
>> build.
>> 
<snip>
>> -# is impossible without a --enable-foo that exits if a feature is not found.
>> +# is impossible without a --enable-foo that exits if a feature is not
>> +# found.
>
> Why did you wrap the second long line, but not the first one?

Hmm I probably just hit return on that line and my editor wrapped it.
Revert or reflow?

>
>> -brlapi=""
>> -curl=""
>> +default_feature=""
>> +# parse CC options second
>> +for opt do
>> +  optarg=$(expr "x$opt" : 'x[^=]*=\(.*\)')
>> +  case "$opt" in
>> +      --without-default-features)
>> +          default_feature="no"
>> +  ;;
>> +  esac
>> +done
>> +
>> +brlapi="$default_feature"
>> +curl="$default_feature"
>>  iconv="auto"
>>  curses="auto"
>>  docs="auto"
>> @@ -303,52 +315,52 @@ netmap="no"
>>  sdl="auto"
>>  sdl_image="auto"
>>  virtiofsd="auto"
>> -virtfs=""
>> +virtfs="$default_feature"
>
> So this currently only deals with the variables that are pre-initialized to
> "" ... but what about those that are initialized to "auto" ? I think they
> should be handled, too? Well, it can still be done in a later patch, I
> guess.

Most of the auto flags go through to meson which can then squash them
with the -Dauto_features=disabled, but I can fixup the auto's left in
configure with additional patches.

>
> Acked-by: Thomas Huth <thuth@redhat.com>


-- 
Alex Bennée