Re: [PATCH] hw/rtc/twl92230: Add missing 'break'

[Peter Maydell]

On Fri, 11 Dec 2020 at 15:46, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Add missing 'break' to fix:
>
>   hw/rtc/twl92230.c: In function ‘menelaus_write’:
>   hw/rtc/twl92230.c:713:5: error: label at end of compound statement
>     713 |     default:
>         |     ^~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> I noticed Thomas "Compile QEMU with -Wimplicit-fallthrough" series
> and remembered this old patch.
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/rtc/twl92230.c | 1 +
>  1 file changed, 1 insertion(+)

I guess the compiler doesn't care about missing 'break' in
the last case in a switch statement. But I think putting in
the 'break' is better style anyway.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM