Re: [PATCH v11 09/25] i386: move cpu dump out of helper.c into cpu-dump.c

[Claudio Fontana]

On 12/11/20 5:13 PM, Richard Henderson wrote:
> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  target/i386/cpu.h       |   1 +
>>  target/i386/cpu-dump.c  | 537 ++++++++++++++++++++++++++++++++++++++++
>>  target/i386/helper.c    | 514 --------------------------------------
>>  target/i386/meson.build |   1 +
>>  4 files changed, 539 insertions(+), 514 deletions(-)
>>  create mode 100644 target/i386/cpu-dump.c
> 
> There are a fair few "static const char * array[]" that should be "static 
> const
> char * const array[]", but is an existing error and this patch is pure code
> movement.
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> r~
> 

Yes, that code being moved is full of issues, checkpatch goes mad about it.
Probably worth an extra cleanup patch later on.

Claudio