[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: checkpatch.pl block comment detection fail
From: |
Peter Maydell |
Subject: |
Re: checkpatch.pl block comment detection fail |
Date: |
Fri, 11 Dec 2020 23:31:22 +0000 |
On Fri, 11 Dec 2020 at 22:54, Doug Evans <dje@google.com> wrote:
>
> Hi.
>
> The coding style docs don't specify this as being bad:
>
> foo(/*bar=*/true);
>
> which improves readability at the call site.
> It's not a style to be used liberally, but sometimes it's helpful.
>
> Alas checkpatch.pl claims this is a block comment.
>
> Would it be ok if I try to fix checkpatch.pl to treat this as ok?
Well, whether it's good or bad style it's certainly not a block
comment, so it's a bug for checkpatch to call it one. If you want
to dive into that morass of perl feel free :-)
thanks
-- PMM