Re: [PATCH 4/6] hw/arm/virt: Use the pvpanic pci device

[Peter Maydell]

On Wed, 28 Oct 2020 at 14:23, Mihai Carabas <mihai.carabas@oracle.com> wrote:
>
> From: Peng Hao <peng.hao2@zte.com.cn>
>
> Add pvpanic device in arm virt machine config file.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
> ---
>  default-configs/devices/arm-softmmu.mak | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/default-configs/devices/arm-softmmu.mak 
> b/default-configs/devices/arm-softmmu.mak
> index 9a94ebd..4efcca2 100644
> --- a/default-configs/devices/arm-softmmu.mak
> +++ b/default-configs/devices/arm-softmmu.mak
> @@ -44,3 +44,4 @@ CONFIG_FSL_IMX6UL=y
>  CONFIG_SEMIHOSTING=y
>  CONFIG_ALLWINNER_H3=y
>  CONFIG_ACPI_APEI=y
> +CONFIG_PVPANIC=y

This should be done in a Kconfig file, I think, not in
default-configs/. More specifically, if you get the Kconfig
right for the pvpanic pci device when you add it (by giving
it a Kconfig stanza including "default y if PCI_DEVICES")
then all machines which have PCI, including Arm ones, will
cause it to be compiled; so this patch can go away entirely.

thanks
-- PMM