[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 15/32] qdev: Move softmmu properties to qdev-properties-sy
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v4 15/32] qdev: Move softmmu properties to qdev-properties-system.h |
Date: |
Mon, 14 Dec 2020 12:40:41 -0500 |
On Mon, Dec 14, 2020 at 03:25:41PM +0100, Igor Mammedov wrote:
> On Fri, 11 Dec 2020 17:05:12 -0500
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > Move the property types and property macros implemented in
> > qdev-properties-system.c to a new qdev-properties-system.h
> > header.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Changes v1 -> v2:
> > * Move UUID property type too, as it was moved to
> > qdev-properties-system.c in the previous patch
> > ---
[...]
> > diff --git a/audio/audio.h b/audio/audio.h
> > index b883ebfb1f..21fe3226ae 100644
> > --- a/audio/audio.h
> > +++ b/audio/audio.h
> > @@ -28,6 +28,7 @@
> > #include "qemu/queue.h"
> > #include "qapi/qapi-types-audio.h"
> > #include "hw/qdev-properties.h"
> it's already included into new header
> so maybe s/old/new/ here and in other such places?
There's no guarantee that qdev-system-properties.h will always
depend on qdev-properties.h. If a file depends on definitions
from qdev-properties.h, it should include qdev-properties.h
explicitly.
>
> > +#include "hw/qdev-properties-system.h"
> >
> > typedef void (*audio_callback_fn) (void *opaque, int avail);
> >
> > diff --git a/include/hw/block/block.h b/include/hw/block/block.h
> > index 1e8b6253dd..c172cbe65f 100644
> > --- a/include/hw/block/block.h
> > +++ b/include/hw/block/block.h
> > @@ -13,6 +13,7 @@
> >
> > #include "exec/hwaddr.h"
> > #include "qapi/qapi-types-block-core.h"
> > +#include "hw/qdev-properties-system.h"
>
> what for it is included here?
hw/block/block.h has references to DEFINE_PROP_BLOCKSIZE,
DEFINE_PROP_DRIVE, and others.
>
[...]
--
Eduardo
- Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property, (continued)
Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property, Mark Cave-Ayland, 2020/12/15
[PATCH v4 18/32] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/12/11
[PATCH v4 19/32] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/12/11
[PATCH v4 15/32] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/12/11
[PATCH v4 20/32] qdev: Add name parameter to qdev_class_add_property(), Eduardo Habkost, 2020/12/11
[PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create method, Eduardo Habkost, 2020/12/11
[PATCH v4 22/32] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/12/11
[PATCH v4 24/32] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/12/11
[PATCH v4 25/32] qdev: Make qdev_class_add_property() more flexible, Eduardo Habkost, 2020/12/11