qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows()


From: Mark Cave-Ayland
Subject: Re: [PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows()
Date: Tue, 15 Dec 2020 11:45:16 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1

On 11/12/2020 22:05, Eduardo Habkost wrote:

sparc_set_nwindows() is one of the very few property setters that
don't check dev->realized, and there's no reason for it to be
special.  Check dev->realized like the other setters.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Cc: qemu-devel@nongnu.org
---
  target/sparc/cpu.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 701e794eac..6a3299041f 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -798,11 +798,17 @@ static void sparc_get_nwindows(Object *obj, Visitor *v, 
const char *name,
  static void sparc_set_nwindows(Object *obj, Visitor *v, const char *name,
                                 void *opaque, Error **errp)
  {
+    DeviceState *dev = DEVICE(obj);
      const int64_t min = MIN_NWINDOWS;
      const int64_t max = MAX_NWINDOWS;
      SPARCCPU *cpu = SPARC_CPU(obj);
      int64_t value;
+ if (dev->realized) {
+        qdev_prop_set_after_realize(dev, name, errp);
+        return;
+    }
+
      if (!visit_type_int(v, name, &value, errp)) {
          return;
      }

Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]