qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2 07/15] target/riscv: rvb: sign-extend instructions


From: Richard Henderson
Subject: Re: [RFC v2 07/15] target/riscv: rvb: sign-extend instructions
Date: Wed, 16 Dec 2020 10:25:11 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 12/15/20 8:01 PM, frank.chang@sifive.com wrote:
> +static bool trans_sext_h(DisasContext *ctx, arg_sext_h *a)
> +{
> +    REQUIRE_EXT(ctx, RVB);
> +    return gen_unary(ctx, a, &tcg_gen_ext16s_tl);
> +}
> +
> +{

Stray "{".

Presumably a rebase error fixed up in a later patch?
Anyway, with that fixed,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]