[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] configure: remove variable bogus_os
From: |
Thomas Huth |
Subject: |
Re: [PATCH 2/4] configure: remove variable bogus_os |
Date: |
Thu, 17 Dec 2020 10:04:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 17/12/2020 09.50, Paolo Bonzini wrote:
> The condition can be tested also from $targetos, clean up.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configure | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 085a5ad7ff..18af8207d9 100755
> --- a/configure
> +++ b/configure
> @@ -467,7 +467,6 @@ gettext="auto"
> fuse="auto"
> fuse_lseek="auto"
>
> -bogus_os="no"
> malloc_trim="auto"
>
> # parse CC options second
> @@ -620,7 +619,6 @@ else
> # might be going to just print the --help text, or it might
> # be the result of a missing compiler.
> targetos='bogus'
> - bogus_os='yes'
> fi
>
> # Some host OSes need non-standard checks for which CPU to use.
> @@ -2016,7 +2014,7 @@ if test -z "$werror" ; then
> fi
> fi
>
> -if test "$bogus_os" = "yes"; then
> +if test "$targetos" = "bogus"; then
> # Now that we know that we're not printing the help and that
> # the compiler works (so the results of the check_defines we used
> # to identify the OS are reliable), if we didn't recognize the
>
Reviewed-by: Thomas Huth <thuth@redhat.com>