[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] hw/misc/pvpanic: add PCI interface support
From: |
Mihai Carabas |
Subject: |
Re: [PATCH 2/3] hw/misc/pvpanic: add PCI interface support |
Date: |
Tue, 22 Dec 2020 18:03:24 +0200 |
> On 22 Dec 2020, at 17:30, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>
>>
>> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
>> index 259f9c9..e9512ab 100644
>> --- a/include/hw/pci/pci.h
>> +++ b/include/hw/pci/pci.h
>> @@ -108,6 +108,7 @@ extern bool pci_available;
>> #define PCI_DEVICE_ID_REDHAT_MDPY 0x000f
>> #define PCI_DEVICE_ID_REDHAT_NVME 0x0010
>> #define PCI_DEVICE_ID_REDHAT_QXL 0x0100
>> +#define PCI_DEVICE_ID_REDHAT_PVPANIC 0x0101
>
> qxl has 0x100 for historical reasons, otherwise devices are simply
> enumerated upwards. NVME has 0x10, so PVPANIC should simply take
> the next free which is 0x11. Didn't I mention that in my last mail?
>
> thanks,
> Gerd
Sorry, my mistake. I did not read your email carefully. Consider this
modification done.
Waiting for other feedback a couple of days and I will send a new revision with
this update.
Thank you,
Mihai
>