[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type macros |
|
Date: |
Sun, 27 Dec 2020 15:33:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> There's no reason to suffix everything with _DEVICE when the names are
> already unique without it and shorter names are more readable.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/vt82c686.c | 48 +++++++++++++++++++++++------------------------
> 1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
> index 2a0f85dea9..1be1169f83 100644
> --- a/hw/isa/vt82c686.c
> +++ b/hw/isa/vt82c686.c
> @@ -49,8 +49,8 @@ struct VT82C686BState {
> SuperIOConfig superio_conf;
> };
>
> -#define TYPE_VT82C686B_DEVICE "VT82C686B"
> -OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BState, VT82C686B_DEVICE)
> +#define TYPE_VT82C686B "VT82C686B"
> +OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BState, VT82C686B)
Can we name this one VT82C686B_ISA?
- Re: [PATCH 07/12] vt82c686: Remove vt82c686b_isa_init() function, (continued)
- [PATCH 11/12] vt82c686: Rename some functions to better show where they belong, BALATON Zoltan, 2020/12/26
- [PATCH 08/12] vt82c686: Remove vt82c686b_pm_init() function, BALATON Zoltan, 2020/12/26
- [PATCH 09/12] vt82c686: Convert debug printf to trace points, BALATON Zoltan, 2020/12/26
- [PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type macros, BALATON Zoltan, 2020/12/26
- [PATCH 05/12] vt82c686: Split off via-[am]c97 into separate file in hw/audio, BALATON Zoltan, 2020/12/26
- [PATCH 10/12] vt82c686: Remove unneeded includes and defines, BALATON Zoltan, 2020/12/26
- [PATCH 12/12] vt82c686: Do not add floppy, BALATON Zoltan, 2020/12/26