Re: [PATCH 09/12] vt82c686: Convert debug printf to trace points

[Philippe Mathieu-Daudé]

On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/isa/trace-events |  6 ++++++
>  hw/isa/vt82c686.c   | 51 +++++++++++++--------------------------------
>  2 files changed, 21 insertions(+), 36 deletions(-)
...

>          switch (superio_conf->index) {
>          case 0x00 ... 0xdf:
>          case 0xe4:
>          case 0xe5:
> +        case 0xe6 ... 0xe8: /* Should set base port of parallel and serial */
>          case 0xe9 ... 0xed:
>          case 0xf3:
>          case 0xf5:
> @@ -74,18 +68,6 @@ static void superio_ioport_writeb(void *opaque, hwaddr 
> addr, uint64_t data,
>          case 0xfd ... 0xff:
>              can_write = false;
>              break;
> -        case 0xe7:
> -            if ((data & 0xff) != 0xfe) {
> -                DPRINTF("change uart 1 base. unsupported yet\n");
> -                can_write = false;
> -            }
> -            break;
> -        case 0xe8:
> -            if ((data & 0xff) != 0xbe) {
> -                DPRINTF("change uart 2 base. unsupported yet\n");
> -                can_write = false;
> -            }
> -            break;
>          default:
>              break;

This hunk belong to a different patch (does not match the patch
description).