[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/8] hw/mips: Make bootloader addresses unsgined
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 1/8] hw/mips: Make bootloader addresses unsgined |
|
Date: |
Sun, 3 Jan 2021 21:41:38 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/3/21 4:57 PM, Philippe Mathieu-Daudé wrote:
> On 1/2/21 12:15 AM, Philippe Mathieu-Daudé wrote:
>> On 12/15/20 7:41 AM, Jiaxun Yang wrote:
>>> Address should be unsigned anyway, otherwise it may carry
>>> calculations wrongly.
>>>
>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>> ---
>>> hw/mips/fuloong2e.c | 12 ++++++------
>>> hw/mips/malta.c | 22 +++++++++++-----------
>>> 2 files changed, 17 insertions(+), 17 deletions(-)
>>
>> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Can you send a follow-up patch for hw/mips/mipssim.c?
Bah as it is trivial, I will squash in your patch.