Re: [PATCH 1/1] vl.c: do not execute trace_init_backends() before daemonizing

[Paolo Bonzini]

On 05/01/21 19:03, Daniel Henrique Barboza wrote:
> +    /*
> +     * The trace backend must be initialized before daemonizing.

after, not before. :)

With this fixed,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> +     * trace_init_backends() will call st_init(), which will create the
> +     * trace thread in the parent, and also register st_flush_trace_buffer()
> +     * in atexit(). This function will force the parent to wait for the
> +     * writeout thread to finish, which will not occur, and the parent
> +     * process will be left in the host.
> +     */
> +    if (!trace_init_backends()) {
> +        exit(1);
> +    }
> +    trace_init_file();
> +