[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] meson: fix Cocoa option in summary

From: Paolo Bonzini
Subject: Re: [PATCH v2] meson: fix Cocoa option in summary
Date: Thu, 7 Jan 2021 12:36:20 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

On 30/12/20 23:16, Chris Hofstaedtler wrote:
Cocoa support was always shown as "no", even it if was enabled.

Fixes: b4e312e953b ("configure: move cocoa option to Meson")
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
  meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 372576f82c..1112ca8fc2 100644
--- a/meson.build
+++ b/meson.build
@@ -2082,7 +2082,7 @@ summary_info += {'strip binaries':    get_option('strip')}
  summary_info += {'profiler':          config_host.has_key('CONFIG_PROFILER')}
  summary_info += {'static build':      config_host.has_key('CONFIG_STATIC')}
  if targetos == 'darwin'
-  summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
+  summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', 
  # TODO: add back version
  summary_info += {'SDL support':       sdl.found()}

Using config_host_data makes sense, however "cocoa.found()" is more consistent with the surrounding code.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]