[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: fix ncurses detection on macOS

From: Paolo Bonzini
Subject: Re: [PATCH] meson: fix ncurses detection on macOS
Date: Thu, 7 Jan 2021 12:47:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

On 28/12/20 16:16, Chris Hofstaedtler wrote:
Without this, meson fails with "curses package not usable"
when using ncurses 6.2. Apparently the wide functions
(addwstr, etc) are hidden behind the extra define, and
meson does not define it at that detection stage.

Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
  meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 9c152a85bd..7b9d92c14a 100644
--- a/meson.build
+++ b/meson.build
@@ -510,7 +510,7 @@ if have_system and not get_option('curses').disabled()
    msg = get_option('curses').enabled() ? 'curses library not found' : ''
    if curses.found()
-    if cc.links(curses_test, dependencies: [curses])
+    if cc.links(curses_test, args: '-DNCURSES_WIDECHAR', dependencies: 
        curses = declare_dependency(compile_args: '-DNCURSES_WIDECHAR', 
dependencies: [curses])
        msg = 'curses package not usable'

Already fixed by commit 0dbce6efb5ff2e7113734d3a0cabbf87fc56feec

    meson: fix detection of curses with pkgconfig

    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Sorry for the delay in applying it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]