[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/5] block/scsi: correctly emulate the VPD block limits pa

From: Max Reitz
Subject: Re: [PATCH v3 5/5] block/scsi: correctly emulate the VPD block limits page
Date: Thu, 7 Jan 2021 14:44:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

On 17.12.20 17:56, Maxim Levitsky wrote:
When the device doesn't support the VPD block limits page, we emulate it even
for SCSI passthrough.

As a part of the emulation we need to add it to the 'Supported VPD Pages'

The code that does this adds it to the page, but it doesn't increase the length
of the data to be copied to the guest, thus the guest never sees the VPD block
limits page as supported.

Isn’t the problem more generally that if there is a block limits page, the last supported page is cut off (which perhaps more likely than not is the block limits page (given that it’s 0xb0, which relatively high))?

Bump the transfer size by 1 in this case.

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
  hw/scsi/scsi-generic.c | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

Anyway, looks good to me, though I have a hard time following the code, which yields a rather weak:

Reviewed-by: Max Reitz <mreitz@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]