[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/13] KVM: Simplify dirty log sync in kvm_set_phys_mem
From: |
Peter Xu |
Subject: |
[PATCH v4 09/13] KVM: Simplify dirty log sync in kvm_set_phys_mem |
Date: |
Fri, 8 Jan 2021 11:50:46 -0500 |
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on. The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each kvmslot in the section.
With the two helpers that we just introduced, it's very easy to do it right now
by calling the helpers.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
accel/kvm/kvm-all.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index c7c7627c82..9cb06ec4d1 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1171,7 +1171,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
goto out;
}
if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
- kvm_physical_sync_dirty_bitmap(kml, section);
+ kvm_slot_get_dirty_log(kvm_state, mem);
+ kvm_slot_sync_dirty_pages(mem);
}
/* unregister the slot */
--
2.26.2
- [PATCH v4 00/13] KVM: Dirty ring support (QEMU part), Peter Xu, 2021/01/08
- [PATCH v4 02/13] Update linux headers to 5.11-rc2, Peter Xu, 2021/01/08
- [PATCH v4 03/13] memory: Introduce log_sync_global() to memory listener, Peter Xu, 2021/01/08
- [PATCH v4 01/13] update-linux-headers: Include const.h, Peter Xu, 2021/01/08
- [PATCH v4 04/13] KVM: Fixup kvm_log_clear_one_slot() ioctl return check, Peter Xu, 2021/01/08
- [PATCH v4 05/13] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2021/01/08
- [PATCH v4 06/13] KVM: Create the KVMSlot dirty bitmap on flag changes, Peter Xu, 2021/01/08
- [PATCH v4 07/13] KVM: Provide helper to get kvm dirty log, Peter Xu, 2021/01/08
- [PATCH v4 08/13] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2021/01/08
- [PATCH v4 09/13] KVM: Simplify dirty log sync in kvm_set_phys_mem,
Peter Xu <=
- [PATCH v4 10/13] KVM: Cache kvm slot dirty bitmap size, Peter Xu, 2021/01/08
- [PATCH v4 11/13] KVM: Add dirty-gfn-count property, Peter Xu, 2021/01/08
- [PATCH v4 12/13] KVM: Disable manual dirty log when dirty ring enabled, Peter Xu, 2021/01/08
- [PATCH v4 13/13] KVM: Dirty ring support, Peter Xu, 2021/01/08