[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
coverity warning about possible missing error check in v9fs_request()
From: |
Peter Maydell |
Subject: |
coverity warning about possible missing error check in v9fs_request() |
Date: |
Sun, 10 Jan 2021 20:01:25 +0000 |
Hi; Coverity has just come up with a new warning (CID 1438968) about
an unchecked error return value in the 9pfs code. (I'm not sure why
now -- the code in question is unchanged since 2011; probably some
other callsites changed enough to trigger the "other callsites check
return value" heuristic.)
Anyway, in the middle of v9fs_request() is this code:
/* marshal the header details */
proxy_marshal(iovec, 0, "dd", header.type, header.size);
header.size += PROXY_HDR_SZ;
retval = qemu_write_full(proxy->sockfd, iovec->iov_base, header.size);
if (retval != header.size) {
goto close_error;
}
This is apparently the only call to proxy_marshal() that does not
check its return value -- is it missing a check?
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- coverity warning about possible missing error check in v9fs_request(),
Peter Maydell <=