[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 14/14] block/qcow2: refactor qcow2_update_options_prepare

From: Alberto Garcia
Subject: Re: [PATCH v5 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths
Date: Mon, 11 Jan 2021 17:08:27 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Sat 09 Jan 2021 01:58:11 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Keep setting ret close to setting errp and don't merge different error
> paths into one. This way it's more obvious that we don't return
> error without setting errp.
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

I get the idea, but I feel the code is getting innecessarily verbose.

One alternative would be to get rid of all -EINVAL inside the switch
block, take advantage of the existing local_err and follow the block

    if (local_err) {
        error_propagate(errp, local_err);
        ret = -EINVAL;
        goto fail;

But otherwise your solution is correct, so you can keep it if you

Reviewed-by: Alberto Garcia <berto@igalia.com>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]