Re: [PATCH] tests/iotests: drop test 312 from auto group

[Alex Bennée]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 05.01.2021 um 11:04 hat Alex Bennée geschrieben:
>> The "auto" documentation states:
>> 
>>   That means they should run with every QEMU binary (also non-x86)
>> 
>> which is not the case as the check-system-fedora build which only
>> includes a rag tag group of rare and deprecated targets doesn't
>> support the virtio device required.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> I think the better solution would be to do something like in 192 so that
> the test is still run at least for one binary:
>
> if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
>     _notrun "Requires a PC machine"
> fi

The fix is already in so feel free to revert and fix up properly. I
wasn't quite able to follow the logic of how the qemu-system binary is
chosen it seemed a little too much to chance.

>
> Kevin


-- 
Alex Bennée