[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v6 03/11] hw/ssi: imx_spi: Convert some debug printf()s to tr
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v6 03/11] hw/ssi: imx_spi: Convert some debug printf()s to trace events |
Date: |
Tue, 12 Jan 2021 19:35:21 +0100 |
Convert some DPRINTF() to trace events.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/ssi/imx_spi.c | 8 ++++----
hw/ssi/trace-events | 7 +++++++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
index 40f72c36b61..35ab33c0511 100644
--- a/hw/ssi/imx_spi.c
+++ b/hw/ssi/imx_spi.c
@@ -14,6 +14,7 @@
#include "migration/vmstate.h"
#include "qemu/log.h"
#include "qemu/module.h"
+#include "trace.h"
#ifndef DEBUG_IMX_SPI
#define DEBUG_IMX_SPI 0
@@ -232,7 +233,7 @@ static void imx_spi_reset(DeviceState *dev)
{
IMXSPIState *s = IMX_SPI(dev);
- DPRINTF("\n");
+ trace_imx_spi_reset();
memset(s->regs, 0, sizeof(s->regs));
@@ -290,7 +291,7 @@ static uint64_t imx_spi_read(void *opaque, hwaddr offset,
unsigned size)
break;
}
- DPRINTF("reg[%s] => 0x%" PRIx32 "\n", imx_spi_reg_name(index), value);
+ trace_imx_spi_read(index, imx_spi_reg_name(index), value);
imx_spi_update_irq(s);
@@ -310,8 +311,7 @@ static void imx_spi_write(void *opaque, hwaddr offset,
uint64_t value,
return;
}
- DPRINTF("reg[%s] <= 0x%" PRIx32 "\n", imx_spi_reg_name(index),
- (uint32_t)value);
+ trace_imx_spi_write(index, imx_spi_reg_name(index), value);
change_mask = s->regs[index] ^ value;
diff --git a/hw/ssi/trace-events b/hw/ssi/trace-events
index 612d3d6087a..20fcaf32df6 100644
--- a/hw/ssi/trace-events
+++ b/hw/ssi/trace-events
@@ -1,3 +1,5 @@
+# See docs/devel/tracing.txt for syntax documentation.
+
# aspeed_smc.c
aspeed_smc_flash_set_segment(int cs, uint64_t reg, uint64_t start, uint64_t
end) "CS%d segreg=0x%"PRIx64" [ 0x%"PRIx64" - 0x%"PRIx64" ]"
@@ -10,6 +12,11 @@ aspeed_smc_dma_rw(const char *dir, uint32_t flash_addr,
uint32_t dram_addr, uint
aspeed_smc_write(uint64_t addr, uint32_t size, uint64_t data) "@0x%" PRIx64 "
size %u: 0x%" PRIx64
aspeed_smc_flash_select(int cs, const char *prefix) "CS%d %sselect"
+# imx_spi.c
+imx_spi_reset(void) ""
+imx_spi_read(uint32_t index, const char *name, uint32_t value) "index:%u (%s)
value:0x%08x"
+imx_spi_write(uint32_t index, const char *name, uint32_t value) "index:%u (%s)
value:0x%08x"
+
# npcm7xx_fiu.c
npcm7xx_fiu_enter_reset(const char *id, int reset_type) "%s reset type: %d"
--
2.26.2