|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 8/8] configure: automatically parse command line for meson -D options |
Date: | Wed, 13 Jan 2021 15:04:22 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 13/01/21 11:31, Daniel P. Berrangé wrote:
meson-buildoptions.json | 717 ++++++++++++++++++++++++I'm not a fan of seeing this file introduced as it has significant overlap with meson_options.txt. I feel like the latter has enough information present to do an acceptable job for help output. After all that's sufficient if we were using meson directly.
Sorry, I missed this remark. meson-buildoptions.json is not hand-written. It is the result of Meson's own parsing meson_options.txt exported as JSON.
In the commit message "because we parse command-line options before meson is available, the introspection output is stored in the source tree. This is the reason for the unattractive diffstat; the number of JSON lines added is higher than the number of configure lines removed. Of course the latter are code that must be maintained manually and the former is not".
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |