[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

From: Michael S. Tsirkin
Subject: Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed
Date: Wed, 13 Jan 2021 09:17:19 -0500

On Mon, Jan 11, 2021 at 04:59:54PM +0200, Marian Posteuca wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
> > overall looks good.
> > Please add a test case for it, see
> > tests/qtest/bios-tables-test.c for description how to do it
> > an/or at
> >   "[PATCH v3 08/12] tests/acpi: allow updates for expected data files"
> > and follow up patches on the list.
> When you say add a test case, do you mean only updating the binary
> files in tests/data/acpi/{microvm,pc,q35,virt} according to the steps
> at the start of the file bios-tables-test.c? Or do you also mean an actual
> test case to be added in bios-tables-test.c?
> Also the step 6 described in bios-tables-test.c mentions that the diff of
> the ACPI table must be added to the commit log, but my change touches
> all the tables for all architectures so that would mean that I would
> have to create a huge commit log. How should I approach this?

If the changes are the same, you can just write:
the change is the same across all architectures,
and show it.

Something I just tripped over: make sure not to
include "---" lines in the diff. Otherwise git am
can not apply the resulting patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]