[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/7] iotests/129: Fix it

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 0/7] iotests/129: Fix it
Date: Wed, 13 Jan 2021 17:59:24 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

13.01.2021 17:38, Kevin Wolf wrote:
Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
- pylint and mypy complain.
   (Running mypy with the options given in 297.)
   [Patch 4 removes one pylint complaint; patch 7 the rest.]

Should we add it to 297 then to make sure we won't regress?

At some point, I guess we'll want to cover all Python tests, but I
assume it was too much to change in the same series as for the
iotests.py cleanup.


anyone knows, what's the difference between pylint and pylint-3?

I know I can do pip3 install pylint, which brings pylint binary.. Also there is 
pylint fedora package which provides pylint binary and python3-pylint fedora 
package which provides pylint-3 binary, both package names looks so that they 
are... the same?

Also. Interesting, but pylint don't check PEP8 code style (or at least not everything of 
it). For example, pycodestyle has a lot of complains about iotests.py (most of them 
"E302 expected 2 blank lines, found 1").. So, what about adding pycodestyle (or 
may be better flake8 which is pycodestyle + some additional things) to 127 iotest?

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]