[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/19] target/arm: add ARMv8.4-SEL2 extension
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 17/19] target/arm: add ARMv8.4-SEL2 extension |
|
Date: |
Wed, 13 Jan 2021 07:35:09 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 1/13/21 3:12 AM, Rémi Denis-Courmont wrote:
>> if (arm_dc_feature(s, ARM_FEATURE_AARCH64) &&
>> dc_isar_feature(aa64_sel2, s)) {
>> ...
>>
>
> Hmm, yeah. Should this be an ifdef on TARGET_AARCH64 instead?
No, I don't think so. It's not performance critical that we avoid a single bit
test.
> Also do we need to revector the exception code, or leave it mostly duplicated
> as is?
If you see a way to tidy that, great, please. But I don't think it's required
for this patch set.
r~
- [PATCH 06/19] target/arm: declare new AA64PFR0 bit-fields, (continued)
- [PATCH 06/19] target/arm: declare new AA64PFR0 bit-fields, remi . denis . courmont, 2021/01/12
- [PATCH 03/19] target/arm: use arm_is_el2_enabled() where applicable, remi . denis . courmont, 2021/01/12
- [PATCH 11/19] target/arm: do S1_ptw_translate() before address space lookup, remi . denis . courmont, 2021/01/12
- [PATCH 14/19] target/arm: secure stage 2 translation regime, remi . denis . courmont, 2021/01/12
- [PATCH 12/19] target/arm: translate NS bit in page-walks, remi . denis . courmont, 2021/01/12
- [PATCH 07/19] target/arm: add 64-bit S-EL2 to EL exception table, remi . denis . courmont, 2021/01/12
- [PATCH 17/19] target/arm: add ARMv8.4-SEL2 extension, remi . denis . courmont, 2021/01/12
- [PATCH 13/19] target/arm: generalize 2-stage page-walk condition, remi . denis . courmont, 2021/01/12
- [PATCH 16/19] target/arm: revector to run-time pick target EL, remi . denis . courmont, 2021/01/12
- [PATCH 18/19] target/arm: enable Secure EL2 in max CPU, remi . denis . courmont, 2021/01/12
- [PATCH 19/19] target/arm: refactor vae1_tlbmask(), remi . denis . courmont, 2021/01/12
- [PATCH 15/19] target/arm: set HPFAR_EL2.NS on secure stage 2 faults, remi . denis . courmont, 2021/01/12
- Re: [PATCHv5 00/19] ARMv8.4-A Secure EL2, Peter Maydell, 2021/01/19