[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 17/19] target/arm: add ARMv8.4-SEL2 extension

From: Richard Henderson
Subject: Re: [PATCH 17/19] target/arm: add ARMv8.4-SEL2 extension
Date: Wed, 13 Jan 2021 07:35:09 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 1/13/21 3:12 AM, Rémi Denis-Courmont wrote:
>>     if (arm_dc_feature(s, ARM_FEATURE_AARCH64) &&
>>         dc_isar_feature(aa64_sel2, s)) {
>>         ...
> Hmm, yeah. Should this be an ifdef on TARGET_AARCH64 instead?

No, I don't think so.  It's not performance critical that we avoid a single bit

> Also do we need to revector the exception code, or leave it mostly duplicated 
> as is?

If you see a way to tidy that, great, please.  But I don't think it's required
for this patch set.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]