[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5] block: report errno when flock fcntl fails

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v5] block: report errno when flock fcntl fails
Date: Wed, 13 Jan 2021 23:45:30 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

13.01.2021 19:44, David Edmondson wrote:
When a call to fcntl(2) for the purpose of adding file locks fails
with an error other than EAGAIN or EACCES, report the error returned
by fcntl.

EAGAIN or EACCES are elided as they are considered to be common
failures, indicating that a conflicting lock is held by another

No errors are elided when removing file locks.

Signed-off-by: David Edmondson<david.edmondson@oracle.com>
- Remove the now unnecessary updates to the test framework (Max).
- Elide the error detail for EAGAIN or EACCES when locking (Kevin,
    sort-of Max).
- Philippe and Vladimir sent Reviewed-by, but things have changed
    noticeably, so I didn't add them (dme).

- Really, really remove the unnecessary updates to the test framework.

- Use a macro to avoid duplicating the EAGAIN/EACCES suppression
- Fix "lock" -> "unlock" (Vladimir).
- Comment on not eliding errors for the unlock case (Vladimir).


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]