[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 08/11] iotests: add testenv.py

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v6 08/11] iotests: add testenv.py
Date: Thu, 14 Jan 2021 14:26:37 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

14.01.2021 14:14, Kevin Wolf wrote:
Am 14.01.2021 um 05:28 hat Vladimir Sementsov-Ogievskiy geschrieben:
09.01.2021 15:26, Vladimir Sementsov-Ogievskiy wrote:
Add TestEnv class, which will handle test environment in a new python
iotests running framework.

Difference with current ./check interface:
- -v (verbose) option dropped, as it is unused

- -xdiff option is dropped, until somebody complains that it is needed
- same for -n option

One more thing dropped is looking for binaries in $build_iotests
directory.  Do someone use this feature? Or we can drop it, and
reimplement when someone report the degradation?

I seem to have socket_scm_helper only there, but you use
self.build_iotests for that, so I suppose this is different from what
you mean?

Yes socket_scm_helper is searched in build_iotests both pre- and after- my 

But for other tools (qemu-img, qemu-io, qemu-nbd, qemu, qemu-storage-daemon) 
old check script first search[1] in build_iotests, and then in standard 
location.. In this commit I don't do the step [1].

My tools and system emulator binaries are in the standard location in
the build directory, not in the iotests build directory, so they don't
need it.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]