qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/25] tests/docker: remove FEATURES env var from template


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 06/25] tests/docker: remove FEATURES env var from templates
Date: Thu, 14 Jan 2021 15:01:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/14/21 2:02 PM, Daniel P. Berrangé wrote:
> In preparation for switching to auto-generated dockerfiles, remove the
> FEATURES env variable. The equivalent functionality can be achieved in
> most cases by just looking for existance of a binary.
> 
> The cases which don't correspond to binaries are simply dropped because
> configure/meson will probe for any requested feature anyway.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  tests/docker/common.rc                        | 19 ++++++++++++++-----
>  tests/docker/dockerfiles/debian10.docker      |  2 --
>  .../dockerfiles/fedora-win32-cross.docker     |  1 -
>  .../dockerfiles/fedora-win64-cross.docker     |  1 -
>  tests/docker/dockerfiles/fedora.docker        |  1 -
>  tests/docker/dockerfiles/ubuntu.docker        |  1 -
>  tests/docker/dockerfiles/ubuntu1804.docker    |  1 -
>  tests/docker/dockerfiles/ubuntu2004.docker    |  1 -
>  tests/docker/run                              |  3 ---
>  tests/docker/test-clang                       |  2 +-
>  tests/docker/test-debug                       |  2 +-
>  tests/docker/test-mingw                       |  3 ++-
>  tests/docker/test-misc                        |  2 +-
>  tests/docker/test-tsan                        |  2 +-
>  14 files changed, 20 insertions(+), 21 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]