[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] osdep.h: Remove <sys/signal.h> include

From: John Snow
Subject: Re: [PATCH v2] osdep.h: Remove <sys/signal.h> include
Date: Thu, 14 Jan 2021 17:01:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/13/21 4:56 PM, Michael Forney wrote:
Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
(apart from two .c files). The POSIX standard location for this
header is just <signal.h> and in fact, OpenBSD's signal.h includes
sys/signal.h itself.

Unconditionally including <sys/signal.h> on musl causes warnings
for just about every source file:

   /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include 
<sys/signal.h> to <signal.h> [-Wcpp]
       1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>
         |  ^~~~~~~

Since there don't seem to be any platforms which require including
<sys/signal.h> in addition to <signal.h>, and some platforms like
Haiku lack it completely, just remove it.

Tested building on OpenBSD after removing this include.

Signed-off-by: Michael Forney <mforney@mforney.org>
Reviewed-by: Eric Blake <eblake@redhat.com>

I ran into this myself when testing an Alpine linux build with musl.

Seems to certainly cut down on the number of errors seen when building in Alpine. There's still a few more, but there's definitely less.

Tested-by: John Snow <jsnow@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]