[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cpu_exec_step_atomic: update the cpu running flag

From: Richard Henderson
Subject: Re: [PATCH] cpu_exec_step_atomic: update the cpu running flag
Date: Fri, 15 Jan 2021 13:05:32 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 9/21/20 9:42 PM, Douglas Crosher wrote:
> The cpu_exec_step_atomic() function is called with the cpu->running
> clear and proceeds to run target code without setting this flag. If
> this target code generates an exception then handle_cpu_signal() will
> unnecessarily abort.
> For example if atomic code generates a memory protection fault.
> This patch at least sets and clears this running flag.
> The related code paths look rather convoluted and it is not immediately clear
> that this patch comprehensively addresses the issue, but it might at least
> direct people to a problem, and it might be an incremental improvement, and it
> gets some code running here. The patch adds some assertions to help detect
> other cases.
> Signed-off-by: Douglas Crosher <dtc-ubuntu@scieneer.com>

Sorry this got overlooked, but better late than never.
Yes, this looks right, thanks.

Queued to tcg-next.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]