[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2? v3 3/9] hw/usb: reorder fields in UASStatus
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH-for-5.2? v3 3/9] hw/usb: reorder fields in UASStatus |
Date: |
Mon, 18 Jan 2021 17:09:58 +0100 |
Hi,
> > It would seem that the copy is limited to at most sizeof(uas_iu),
> > so even if we had anything in add_cdb[], that wouldn't be copied
> > here?
> >
> > Is this intended?
>
> Gerd, do you know?
Don't remember, it's been a few years ago ...
Given that neither add_cdb nor add_cdb_length fields are checked
anywhere in the code it is probably save to just comment out the
add_cdb field. Should we ever need to look at add_cdb at some
point in the future we can figure some better way deal with it,
in the simplest case just give it a fixed size based on the needs.
take care,
Gerd