|
| From: | Richard Henderson |
| Subject: | Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer |
| Date: | Mon, 18 Jan 2021 07:14:12 -1000 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 1/15/21 1:00 PM, Alistair Francis wrote:
> +bool riscv_is_32bit(RISCVHartArrayState *harts)
> {
> - RISCVCPU hart = harts.harts[0];
> + RISCVCPU hart = harts->harts[0];
This is a large structure copy as well.
> return riscv_cpu_is_32bit(&hart.env);
> }
Better as
&harts->harts[0].env
surely.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |