[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler
Date: Mon, 18 Jan 2021 20:36:25 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

18.01.2021 18:13, Kevin Wolf wrote:
Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
Add new handler to get aio context and implement it in all child
classes. Add corresponding public interface to be used soon.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Hm, are you going to introduce cases where parent and child context
don't match, or why is this a useful function?

Even if so, I feel it shouldn't be any of the child's business what
AioContext the parent uses.

Well, maybe the rest of the series will answer this.

It's for the following patch, to not pass parent (as opaque) with it's class, 
and with its ctx in separate. Just to simplify the interface of the function, 
we are going to work with a lot.

Hm. I'll take this opportunity to say, that the terminology that calls graph edge 
"BdrvChild" always leads to the mess between parents and children.. 
"child_class" is a class of parent.. list of parents is list of children... It all would 
be a lot simpler to understand if BdrvChild was BdrvEdge or something like this.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]