[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

From: Kevin Wolf
Subject: Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists
Date: Tue, 19 Jan 2021 13:33:37 +0100

Am 18.01.2021 um 17:30 hat Paolo Bonzini geschrieben:
> Looking at all merge-lists QemuOptsList, here is how they access their
> QemuOpts:
> reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o")
>       qemu_opts_find(&reopen_opts, NULL)
> empty_opts in qemu-io.c ("qemu-io open -o")
>       qemu_opts_find(&empty_opts, NULL)
> qemu_rtc_opts ("-rtc")
>       qemu_find_opts_singleton("rtc")
> qemu_machine_opts ("-M")
>       qemu_find_opts_singleton("machine")
> qemu_boot_opts ("-boot")
>       QTAILQ_FIRST(&qemu_find_opts("bootopts")->head)
> qemu_name_opts ("-name")
>       qemu_opts_foreach->parse_name
>       parse_name does not use id
> qemu_mem_opts ("-m")
>       qemu_find_opts_singleton("memory")
> qemu_icount_opts ("-icount")
>       qemu_opts_foreach->do_configuree_icount
>       do_configure_icount->icount_configure
>       icount_configure does not use id

qemu_action_opts has been added since the last version of this series.
It's fine, too (gets converted to a QAPI type that doesn't have an "id"
field), but you may want to update the commit message.

With this:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]