Re: [PATCH v2 08/22] tcg/mips: Split out target constraints to tcg-target-con-str.h

[Peter Maydell]

On Fri, 15 Jan 2021 at 21:14, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/mips/tcg-target-con-str.h | 24 ++++++++++++
>  tcg/mips/tcg-target.h         |  1 +
>  tcg/mips/tcg-target.c.inc     | 72 ++++++++---------------------------
>  3 files changed, 41 insertions(+), 56 deletions(-)
>  create mode 100644 tcg/mips/tcg-target-con-str.h

> -    case 'Z':
> -        /* We are cheating a bit here, using the fact that the register
> -           ZERO is also the register number 0. Hence there is no need
> -           to check for const_args in each instruction. */
> -        ct->ct |= TCG_CT_CONST_ZERO;

This comment seems like it's worth retaining somewhere.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM